Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle the user code generation duplication #23

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: handle the user code generation duplication #23

merged 1 commit into from
May 7, 2024

Conversation

wood-push-melon
Copy link

This pull request tries to resolve the user code generation duplication issue. Currently, the implementation will try a maximum of 3 times to generate a unique user code. When it reaches the maximum number of attempts, an error will be thrown.

@wood-push-melon wood-push-melon marked this pull request as ready for review April 29, 2024 23:36
@wood-push-melon wood-push-melon requested a review from a team as a code owner April 29, 2024 23:36
nsklikas
nsklikas reviewed Apr 30, 2024
View reviewed changes
Copy link

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, only minor comments. I think the approach described in your comment sounds better

handler/rfc8628/auth_handler.go Outdated Show resolved Hide resolved
handler/rfc8628/auth_handler.go Outdated Show resolved Hide resolved
shipperizer
shipperizer reviewed Apr 30, 2024
View reviewed changes
handler/rfc8628/auth_handler.go Outdated Show resolved Hide resolved
handler/rfc8628/auth_handler.go Outdated Show resolved Hide resolved
shipperizer
shipperizer reviewed May 6, 2024
View reviewed changes
Copy link

@shipperizer shipperizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i d say rewrite commit message or squash them into one and then it s good to go

(comments are minor)

handler/rfc8628/auth_handler.go Outdated Show resolved Hide resolved
handler/rfc8628/auth_handler.go Outdated Show resolved Hide resolved
handler/rfc8628/auth_handler.go Outdated Show resolved Hide resolved
@wood-push-melon wood-push-melon merged commit e62ac07 into canonical May 7, 2024
6 checks passed
@wood-push-melon wood-push-melon deleted the IAM-841 branch May 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsklikas nsklikas nsklikas left review comments

@shipperizer shipperizer shipperizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wood-push-melon @shipperizer @nsklikas